mfd: Drop modifying mc13xxx driver's id_table in probe
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 16 Jul 2012 13:40:17 +0000 (15:40 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Mon, 16 Jul 2012 13:40:17 +0000 (15:40 +0200)
commit8b8495532c6ba85221b0f9757e1581b52ed66c9a
treebf221b7aac59b435b7e895ed51bb7cff81ddd640
parentc600040f0d1fecbbe4582c00d99d8f5c4ffd0390
mfd: Drop modifying mc13xxx driver's id_table in probe

This was introduced in commit

        876989d (mfd: Add device tree probe support for mc13xxx)

for spi and later while introducing support for i2c copied to the i2c
driver.

Modifying driver details is very strange, for example probing an
mc13892 device (instantiated via dt) removes the driver's ability to
handle (traditionally probed) mc13783 devices in this case.
I'm not aware of any problems that make this hack necessary and if
there were some, they'd have to be fixed in the spi/i2c core, not in
a driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/mc13xxx-i2c.c
drivers/mfd/mc13xxx-spi.c