sctp: only drop the reference on the datamsg after sending a msg
authorlucien <lucien.xin@gmail.com>
Sat, 5 Dec 2015 07:19:27 +0000 (15:19 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 6 Dec 2015 18:25:12 +0000 (13:25 -0500)
commit8b570dc9f7b634e853866ce40097c0342ac5bb81
tree646708d19ab120712d0277c0b5840f30e0b55c3b
parent69b5777f2e5779bb987d4a25a33401d5ac257c14
sctp: only drop the reference on the datamsg after sending a msg

If the chunks are enqueued successfully but sctp_cmd_interpreter()
return err to sctp_sendmsg() (mainly because of no mem), the chunks will
get re-queued, but we are dropping the reference and freeing them.

The fix is to just drop the reference on the datamsg just as it had
succeeded, as:
 - if the chunks weren't queued, this is enough to get them freed.
 - if they were queued, they will get freed when they finally get out or
 discarded.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c