nrwt: clean up exception handling and make sure we log some more failures
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Jul 2012 00:14:25 +0000 (00:14 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Jul 2012 00:14:25 +0000 (00:14 +0000)
commit8b3f14ae5f8e7a7ee456672043e612cbd30ca229
tree4042b92e27e3954dc2bb5ddf15ff738164725f73
parent8ea477632a7c16d259af96572166e03421f12657
nrwt: clean up exception handling and make sure we log some more failures
https://bugs.webkit.org/show_bug.cgi?id=90503

Reviewed by Ojan Vafai.

There were several places where exceptions weren't getting
logged, most notably if you passed a bad value to --platform.
This change tests that and cleans things up a bit; more cleanup
will be possible when we rework the manager_worker_broker code.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_BrokerConnection.raise_exception):
(_InlineWorkerConnection.raise_exception):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.run):
(Worker.kill_driver):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory.get):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unsupported_platfrom):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py
Tools/Scripts/webkitpy/layout_tests/controllers/worker.py
Tools/Scripts/webkitpy/layout_tests/port/factory.py
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py