power: supply: core: fix memory leak in HWMON error path
authorQiushi Wu <wu000273@umn.edu>
Sat, 2 May 2020 23:33:38 +0000 (18:33 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jun 2020 07:31:20 +0000 (09:31 +0200)
commit8b28e5c35d3272e367953fba52cd72fd86573488
tree930d47a2826ace68af8467fab433d20afc0d4a18
parent6050811edffbe9ce1b264e1557875f81b64f40e4
power: supply: core: fix memory leak in HWMON error path

commit 1d7a7128a2e9e1f137c99b0a44e94d70a77343e3 upstream.

In function power_supply_add_hwmon_sysfs(), psyhw->props is
allocated by bitmap_zalloc(). But this pointer is not deallocated
when devm_add_action fail,  which lead to a memory leak bug. To fix
this, we replace devm_add_action with devm_add_action_or_reset.

Cc: stable@kernel.org
Fixes: e67d4dfc9ff19 ("power: supply: Add HWMON compatibility layer")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/supply/power_supply_hwmon.c