Refactor read and write buffers.
authorcommit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Thu, 30 Jan 2014 18:58:24 +0000 (18:58 +0000)
committercommit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Thu, 30 Jan 2014 18:58:24 +0000 (18:58 +0000)
commit8b0e8ac5f582de80356019406e2975079bf0829d
tree9f43589895207dfcf422d41318b371c9540f1ada
parent5fbccb35eb9e7e8cfa3c6b02026206db77990324
Refactor read and write buffers.

Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer
a step each in the hierarchy.

What used to be this:

SkFlattenableWriteBuffer -> SkOrderedWriteBuffer
SkFlattenableReadBuffer  -> SkOrderedReadBuffer
SkFlattenableReadBuffer  -> SkValidatingReadBuffer

is now

SkWriteBuffer
SkReadBuffer -> SkValidatingReadBuffer

Benefits:
  - code is simpler, names are less wordy
  - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed
  - write buffers are completely devirtualized, important for record speed

This refactoring was mostly mechanical.  You aren't going to find anything
interesting in files with less than 10 lines changed.

BUG=skia:
R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/134163010

git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
182 files changed:
gm/imagefiltersbase.cpp
gm/imagefiltersgraph.cpp
gm/texteffects.cpp
gyp/core.gypi
include/core/SkAnnotation.h
include/core/SkBitmap.h
include/core/SkColorFilter.h
include/core/SkColorShader.h
include/core/SkColorTable.h
include/core/SkComposeShader.h
include/core/SkDrawLooper.h
include/core/SkEmptyShader.h
include/core/SkFlattenable.h
include/core/SkFlattenableBuffers.h
include/core/SkImageFilter.h
include/core/SkImageInfo.h
include/core/SkMallocPixelRef.h
include/core/SkMaskFilter.h
include/core/SkPaint.h
include/core/SkPaintOptionsAndroid.h
include/core/SkPathEffect.h
include/core/SkPicture.h
include/core/SkPixelRef.h
include/core/SkRasterizer.h
include/core/SkReadBuffer.h [new file with mode: 0644]
include/core/SkShader.h
include/core/SkUnitMapper.h
include/core/SkWriteBuffer.h [new file with mode: 0644]
include/core/SkXfermode.h
include/effects/Sk1DPathEffect.h
include/effects/Sk2DPathEffect.h
include/effects/SkAvoidXfermode.h
include/effects/SkBicubicImageFilter.h
include/effects/SkBitmapSource.h
include/effects/SkBlurDrawLooper.h
include/effects/SkBlurImageFilter.h
include/effects/SkColorFilterImageFilter.h
include/effects/SkColorMatrixFilter.h
include/effects/SkComposeImageFilter.h
include/effects/SkCornerPathEffect.h
include/effects/SkDashPathEffect.h
include/effects/SkDiscretePathEffect.h
include/effects/SkDisplacementMapEffect.h
include/effects/SkDropShadowImageFilter.h
include/effects/SkEmbossMaskFilter.h
include/effects/SkKernel33MaskFilter.h
include/effects/SkLayerDrawLooper.h
include/effects/SkLayerRasterizer.h
include/effects/SkLerpXfermode.h
include/effects/SkLightingImageFilter.h
include/effects/SkLumaColorFilter.h
include/effects/SkMagnifierImageFilter.h
include/effects/SkMatrixConvolutionImageFilter.h
include/effects/SkMergeImageFilter.h
include/effects/SkMorphologyImageFilter.h
include/effects/SkOffsetImageFilter.h
include/effects/SkPerlinNoiseShader.h
include/effects/SkPictureImageFilter.h
include/effects/SkPixelXorXfermode.h
include/effects/SkRectShaderImageFilter.h
include/effects/SkResizeImageFilter.h
include/effects/SkStippleMaskFilter.h
include/effects/SkTableMaskFilter.h
include/effects/SkTestImageFilters.h
include/effects/SkTileImageFilter.h
include/effects/SkTransparentShader.h
include/effects/SkXfermodeImageFilter.h
include/images/SkImageRef.h
include/images/SkImageRef_GlobalPool.h
include/utils/SkUnitMappers.h
samplecode/ClockFaceView.cpp
samplecode/SampleAll.cpp
samplecode/SampleSlides.cpp
samplecode/SampleText.cpp
src/core/SkAnnotation.cpp
src/core/SkBitmap.cpp
src/core/SkBitmapHeap.cpp
src/core/SkBitmapProcShader.cpp
src/core/SkBitmapProcShader.h
src/core/SkBlitter.cpp
src/core/SkColorFilter.cpp
src/core/SkColorTable.cpp
src/core/SkComposeShader.cpp
src/core/SkData.cpp
src/core/SkDraw.cpp
src/core/SkFilterShader.cpp
src/core/SkFilterShader.h
src/core/SkFlattenable.cpp
src/core/SkFlattenableBuffers.cpp [deleted file]
src/core/SkFlattenableSerialization.cpp
src/core/SkImageFilter.cpp
src/core/SkImageInfo.cpp
src/core/SkMallocPixelRef.cpp
src/core/SkOrderedReadBuffer.h [deleted file]
src/core/SkOrderedWriteBuffer.h [deleted file]
src/core/SkPaint.cpp
src/core/SkPaintOptionsAndroid.cpp
src/core/SkPathEffect.cpp
src/core/SkPathHeap.cpp
src/core/SkPathHeap.h
src/core/SkPictureFlat.h
src/core/SkPicturePlayback.cpp
src/core/SkPicturePlayback.h
src/core/SkPixelRef.cpp
src/core/SkReadBuffer.cpp [moved from src/core/SkOrderedReadBuffer.cpp with 80% similarity]
src/core/SkScalerContext.cpp
src/core/SkShader.cpp
src/core/SkValidatingReadBuffer.cpp
src/core/SkValidatingReadBuffer.h
src/core/SkWriteBuffer.cpp [moved from src/core/SkOrderedWriteBuffer.cpp with 77% similarity]
src/core/SkXfermode.cpp
src/core/SkXfermode_proccoeff.h
src/effects/Sk1DPathEffect.cpp
src/effects/Sk2DPathEffect.cpp
src/effects/SkAlphaThresholdFilter.cpp
src/effects/SkArithmeticMode.cpp
src/effects/SkAvoidXfermode.cpp
src/effects/SkBicubicImageFilter.cpp
src/effects/SkBitmapSource.cpp
src/effects/SkBlurDrawLooper.cpp
src/effects/SkBlurImageFilter.cpp
src/effects/SkBlurMaskFilter.cpp
src/effects/SkColorFilterImageFilter.cpp
src/effects/SkColorFilters.cpp
src/effects/SkColorMatrix.cpp
src/effects/SkColorMatrixFilter.cpp
src/effects/SkComposeImageFilter.cpp
src/effects/SkCornerPathEffect.cpp
src/effects/SkDashPathEffect.cpp
src/effects/SkDiscretePathEffect.cpp
src/effects/SkDisplacementMapEffect.cpp
src/effects/SkDropShadowImageFilter.cpp
src/effects/SkEmbossMaskFilter.cpp
src/effects/SkKernel33MaskFilter.cpp
src/effects/SkLayerDrawLooper.cpp
src/effects/SkLayerRasterizer.cpp
src/effects/SkLerpXfermode.cpp
src/effects/SkLightingImageFilter.cpp
src/effects/SkLumaColorFilter.cpp
src/effects/SkMagnifierImageFilter.cpp
src/effects/SkMatrixConvolutionImageFilter.cpp
src/effects/SkMergeImageFilter.cpp
src/effects/SkMorphologyImageFilter.cpp
src/effects/SkOffsetImageFilter.cpp
src/effects/SkPerlinNoiseShader.cpp
src/effects/SkPictureImageFilter.cpp
src/effects/SkPixelXorXfermode.cpp
src/effects/SkRectShaderImageFilter.cpp
src/effects/SkResizeImageFilter.cpp
src/effects/SkTableColorFilter.cpp
src/effects/SkTableMaskFilter.cpp
src/effects/SkTestImageFilters.cpp
src/effects/SkTileImageFilter.cpp
src/effects/SkXfermodeImageFilter.cpp
src/effects/gradients/SkGradientShader.cpp
src/effects/gradients/SkGradientShaderPriv.h
src/effects/gradients/SkLinearGradient.cpp
src/effects/gradients/SkLinearGradient.h
src/effects/gradients/SkRadialGradient.cpp
src/effects/gradients/SkRadialGradient.h
src/effects/gradients/SkSweepGradient.cpp
src/effects/gradients/SkSweepGradient.h
src/effects/gradients/SkTwoPointConicalGradient.cpp
src/effects/gradients/SkTwoPointConicalGradient.h
src/effects/gradients/SkTwoPointRadialGradient.cpp
src/effects/gradients/SkTwoPointRadialGradient.h
src/images/SkImageRef.cpp
src/images/SkImageRef_GlobalPool.cpp
src/images/SkImageRef_ashmem.cpp
src/images/SkImageRef_ashmem.h
src/lazy/SkCachingPixelRef.h
src/opts/SkXfermode_opts_arm_neon.cpp
src/opts/SkXfermode_opts_arm_neon.h
src/pipe/SkGPipeRead.cpp
src/pipe/SkGPipeWrite.cpp
src/utils/SkUnitMappers.cpp
tests/AndroidPaintTest.cpp
tests/BitmapHeapTest.cpp
tests/ColorFilterTest.cpp
tests/DataRefTest.cpp
tests/FlatDataTest.cpp
tests/SerializationTest.cpp