venus: Drop incorrectly-used always-true pipeline vars
authorLina Versace <linyaa@google.com>
Fri, 4 Aug 2023 18:11:28 +0000 (11:11 -0700)
committerLina Versace <linyaa@google.com>
Wed, 18 Oct 2023 19:12:17 +0000 (12:12 -0700)
commit8b0b1f5d39f577b6869af8860ef6d2e8691b7e1b
treed0b93caf1940abcc59b8e41b8ed601df4c59a703
parentb0530d2c94ba63bf1b0da61bbbc607264712b028
venus: Drop incorrectly-used always-true pipeline vars

When writing vn_fix_graphics_pipeline_create_info() long ago, I defined
some always-true dummy vars that represented some
VkGraphicsPipelineLibraryFlagsEXT. In the conditions that decide which
state to fixup, I used the dummy vars.

My intent was that this would ease the implementation of
VK_EXT_graphics_pipeline_library, because some of the GPL fixup logic
would already be present.  I was wrong. After I studied GPL more,
I discovered that the conditions were using the dummy vars incorrectly.
The incorrect usage produced no bugs, because the vars are always true.

Delete the dummy vars.

Signed-off-by: Lina Versace <linyaa@google.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22419>
src/virtio/vulkan/vn_pipeline.c