tools build: Fix feature detect clean for out of source builds
authorJames Clark <james.clark@arm.com>
Mon, 16 Aug 2021 13:07:05 +0000 (14:07 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 1 Sep 2021 14:26:01 +0000 (11:26 -0300)
commit8af52e69772d053bc7caab12ad1c59f18ef2e3e2
tree1e1b459f759d1d29a192bfba19ce377ceec9c5b0
parent79e7ed56d7e8899827d977d9dbd381b0ddb7a52a
tools build: Fix feature detect clean for out of source builds

Currently the clean target when using O= isn't cleaning the feature
detect output. This is because O= and OUTPUT= are set to canonical
paths. For example in tools/perf/Makefile:

  FULL_O := $(shell cd $(PWD); readlink -f $(O) || echo $(O))

This means that OUTPUT ends in a / and most usages prepend it to a file
without adding an extra /. This line that was changed adds an extra /
before the 'feature' folder but not to the end, resulting in a clean
command like this:

  rm -f /tmp/build//featuretest-all.bin ...

After the change the clean command looks like this:

  rm -f /tmp/build/feature/test-all.bin ...

Fixes: 762323eb39a257c3 ("perf build: Move feature cleanup under tools/build")
Signed-off-by: James Clark <james.clark@arm.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lore.kernel.org/lkml/20210816130705.1331868-1-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/build/Makefile