media: ddbridge: fix possible buffer overflow in ddb_ports_init()
authorDaniel Scheller <d.scheller@gmx.net>
Sat, 12 Aug 2017 11:55:57 +0000 (07:55 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 11:07:19 +0000 (07:07 -0400)
commit8ac9fd4348677cb2ead6776b9f8042c952a3f67c
treee0c45194d2a38ce578277bc5beab811491b8fb8e
parentf597f2a8fce27b067ed5ad58314bdfbb219d2ffe
media: ddbridge: fix possible buffer overflow in ddb_ports_init()

Report from smatch:

  drivers/media/pci/ddbridge/ddbridge-core.c:2659 ddb_ports_init() error: buffer overflow 'dev->port' 32 <= u32max

Fix by making sure "p" is greater than zero before checking for
"dev->port[].type == DDB_CI_EXTERNAL_XO2".

Cc: Ralph Metzler <rjkm@metzlerbros.de>
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Tested-by: Richard Scobie <r.scobie@clear.net.nz>
Tested-by: Jasmin Jessich <jasmin@anw.at>
Tested-by: Dietmar Spingler <d_spingler@freenet.de>
Tested-by: Manfred Knick <Manfred.Knick@t-online.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/ddbridge/ddbridge-core.c