ALSA: hda: patch_realtek: fix empty macro usage in if block
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sat, 11 Jan 2020 21:47:35 +0000 (15:47 -0600)
committerTakashi Iwai <tiwai@suse.de>
Sun, 12 Jan 2020 08:45:09 +0000 (09:45 +0100)
commit8a71821f12a010d7100f9cc1f7b218aff0313c4a
tree6a316e9404d56d4580072a318d001e50af82cc7a
parentf9993480214f1345497875ed363a52b7ef7e33db
ALSA: hda: patch_realtek: fix empty macro usage in if block

GCC reports the following warning with W=1

sound/pci/hda/patch_realtek.c: In function ‘alc269_suspend’:
sound/pci/hda/patch_realtek.c:3616:29: warning: suggest braces around
empty body in an ‘if’ statement [-Wempty-body]
 3616 |   alc5505_dsp_suspend(codec);
      |                             ^

sound/pci/hda/patch_realtek.c: In function ‘alc269_resume’:
sound/pci/hda/patch_realtek.c:3651:28: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
 3651 |   alc5505_dsp_resume(codec);
      |                            ^

This is a classic macro problem and can indeed lead to bad program
flows.

Fix by using the usual "do { } while (0)" pattern

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200111214736.3002-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c