net: sk_clone_lock() should only do get_net() if the parent is not a kernel socket
authorSowmini Varadhan <sowmini.varadhan@oracle.com>
Thu, 30 Jul 2015 13:50:36 +0000 (15:50 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 Jul 2015 22:59:12 +0000 (15:59 -0700)
commit8a68173691f036613e3d4e6bf8dc129d4a7bf383
treeadc6484dea873eb45bb1ed01c4f63676a8bf40f7
parent28e6b67f0b292f557468c139085303b15f1a678f
net: sk_clone_lock() should only do get_net() if the parent is not a kernel socket

The newsk returned by sk_clone_lock should hold a get_net()
reference if, and only if, the parent is not a kernel socket
(making this similar to sk_alloc()).

E.g,. for the SYN_RECV path, tcp_v4_syn_recv_sock->..inet_csk_clone_lock
sets up the syn_recv newsk from sk_clone_lock. When the parent (listen)
socket is a kernel socket (defined in sk_alloc() as having
sk_net_refcnt == 0), then the newsk should also have a 0 sk_net_refcnt
and should not hold a get_net() reference.

Fixes: 26abe14379f8 ("net: Modify sk_alloc to not reference count the
      netns of kernel sockets.")
Acked-by: Eric Dumazet <edumazet@google.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/sock.c