Do not return cacheItem->object if it is still incubating
authorAlbert Astals Cid <albert.astals@canonical.com>
Tue, 21 May 2013 14:09:58 +0000 (16:09 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Thu, 23 May 2013 09:22:56 +0000 (11:22 +0200)
commit8a3d48915c29484c9ffb2fb8f0e3b569a9fe9b44
tree7a6086508cdaa88e37e8ec1ac2c576ac0b59bf1a
parent0e9cd8b4098661bf611fa73a787c58c85e7d7338
Do not return cacheItem->object if it is still incubating

It can happen that cacheItem->object in QQmlDelegateModelPrivate::object
already has a value but that the cacheItem->incubationTask is still
Loading. If we return the object here we can confuse some of QQmlDelegateModel
consumers like QQuickItemView.

E.g. in QQuickItemView if we get to return the object before the createdItem
signal is emitted we will make that when the createdItem signal happens
QQuickItemView::createdItem will be called it will add the item
to unrequestedItems items and will expect that layout/refill will
remove it from unrequestedItems if it is really one of the items we are
creating, but as it has been already created the item will wrongly remain
in unrequestedItems making the item view to act weird

Task-number: QTBUG-28403

Change-Id: I4359391eb2a4012afd3f01d082a99692d63b6639
Reviewed-by: Alan Alpert <aalpert@blackberry.com>
src/qml/types/qqmldelegatemodel.cpp