projects / platform / kernel / linux-starfive.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9dae090) | patch
of: Fix a refcounting bug in __of_attach_node_sysfs()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 20 May 2020 12:04:14 +0000 (15:04 +0300)
committerRob Herring <robh@kernel.org>
Thu, 28 May 2020 01:30:25 +0000 (19:30 -0600)
commit8a325dd06f2358ea0888e4ff1c9ca4bc23bd53f3
tree43b15e49cc02ece48eb1f19eb864e8faba9d4a56tree | snapshot
parent9dae090f4b0aad9e97b621f61ee75e24e2432ac7commit | diff
of: Fix a refcounting bug in __of_attach_node_sysfs()

The problem in this code is that if kobject_add() fails, then it should
call of_node_put(np) to drop the reference count.  I've actually moved
the of_node_get(np) later in the function to avoid needing to do clean
up.

Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/kobj.c diff | blob | history
Domain: System / Kernel;