wifi: ath9k: Fix potential stack-out-of-bounds write in ath9k_wmi_rsp_callback()
authorMinsuk Kang <linuxlovemin@yonsei.ac.kr>
Wed, 4 Jan 2023 12:41:30 +0000 (21:41 +0900)
committerKalle Valo <quic_kvalo@quicinc.com>
Tue, 17 Jan 2023 11:54:25 +0000 (13:54 +0200)
commit8a2f35b9830692f7a616f2f627f943bc748af13a
tree63bb1f32d91174bc09685bcf35945ea451ff0038
parent0af54343a76263a12dbae7fafb64eb47c4a6ad38
wifi: ath9k: Fix potential stack-out-of-bounds write in ath9k_wmi_rsp_callback()

Fix a stack-out-of-bounds write that occurs in a WMI response callback
function that is called after a timeout occurs in ath9k_wmi_cmd().
The callback writes to wmi->cmd_rsp_buf, a stack-allocated buffer that
could no longer be valid when a timeout occurs. Set wmi->last_seq_id to
0 when a timeout occurred.

Found by a modified version of syzkaller.

BUG: KASAN: stack-out-of-bounds in ath9k_wmi_ctrl_rx
Write of size 4
Call Trace:
 memcpy
 ath9k_wmi_ctrl_rx
 ath9k_htc_rx_msg
 ath9k_hif_usb_reg_in_cb
 __usb_hcd_giveback_urb
 usb_hcd_giveback_urb
 dummy_timer
 call_timer_fn
 run_timer_softirq
 __do_softirq
 irq_exit_rcu
 sysvec_apic_timer_interrupt

Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
Signed-off-by: Minsuk Kang <linuxlovemin@yonsei.ac.kr>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230104124130.10996-1-linuxlovemin@yonsei.ac.kr
drivers/net/wireless/ath/ath9k/wmi.c