Fix signed integer overflow in random_r (bug 17343).
authorJoseph Myers <joseph@codesourcery.com>
Tue, 20 Mar 2018 18:25:24 +0000 (18:25 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Tue, 20 Mar 2018 18:25:24 +0000 (18:25 +0000)
commit8a07b0c43c46a480da070efd53a2720195e2256f
tree04a4604ca52bf46526231039c4e60271a75570ec
parentceb54b9b4ff5ef7d518a6e6e415a6897fb77eb67
Fix signed integer overflow in random_r (bug 17343).

Bug 17343 reports that stdlib/random_r.c has code with undefined
behavior because of signed integer overflow on int32_t.  This patch
changes the code so that the possibly overflowing computations use
unsigned arithmetic instead.

Note that the bug report refers to "Most code" in that file.  The
places changed in this patch are the only ones I found where I think
such overflow can occur.

Tested for x86_64 and x86.

[BZ #17343]
* stdlib/random_r.c (__random_r): Use unsigned arithmetic for
possibly overflowing computations.
ChangeLog
stdlib/random_r.c