[X86] Add ExpandLargeFpConvert Pass and enable for X86
authorFreddy Ye <freddy.ye@intel.com>
Thu, 1 Dec 2022 05:47:25 +0000 (13:47 +0800)
committerFreddy Ye <freddy.ye@intel.com>
Thu, 1 Dec 2022 05:47:43 +0000 (13:47 +0800)
commit89f36dd8f32f85bfaf19dfa2cbb12d6622727bfb
tree673469c8bf25a0b2131d6d62489632ad3b264617
parent416e8c6ad529c57f21f46c6f52ded96d3ed239fb
[X86] Add ExpandLargeFpConvert Pass and enable for X86

As stated in
https://discourse.llvm.org/t/rfc-llc-add-expandlargeintfpconvert-pass-for-fp-int-conversion-of-large-bitint/65528,
this implementation is very similar to ExpandLargeDivRem, which expands
‘fptoui .. to’, ‘fptosi .. to’, ‘uitofp .. to’, ‘sitofp .. to’ instructions
with a bitwidth above a threshold into auto-generated functions. This is
useful for targets like x86_64 that cannot lower fp convertions with more
than 128 bits. The expanded nodes are referring from the IR generated by
`compiler-rt/lib/builtins/floattidf.c`, `compiler-rt/lib/builtins/fixdfti.c`,
and etc.

Corner cases:
1. For fp16: as there is no related builtins added in compliler-rt. So I
mainly utilized the fp32 <-> fp16 lib calls to implement.
2. For fp80: as this pass is soft fp emulation and no fp80 instructions can
help in this problem. I recommend users to deprecate this usage. For now, the
implementation uses fp128 as the temporary conversion type and inserts
fptrunc/ext at top/end of the function.
3. For bf16: as clang FE currently doesn't support bf16 algorithm operations
(convert to int, float, +, -, *, ...), this patch doesn't consider bf16 for
now.
4. For unsigned FPToI: since both default hardware behaviors and libgcc are
ignoring "returns 0 for negative input" spec. This pass follows this old way
to ignore unsigned FPToI. See this example:
https://gcc.godbolt.org/z/bnv3jqW1M

The end-to-end tests are uploaded at https://reviews.llvm.org/D138261

Reviewed By: LuoYuanke, mgehre-amd

Differential Revision: https://reviews.llvm.org/D137241
26 files changed:
llvm/include/llvm/CodeGen/MachinePassRegistry.def
llvm/include/llvm/CodeGen/Passes.h
llvm/include/llvm/CodeGen/TargetLowering.h
llvm/include/llvm/InitializePasses.h
llvm/lib/CodeGen/CMakeLists.txt
llvm/lib/CodeGen/CodeGen.cpp
llvm/lib/CodeGen/ExpandLargeFpConvert.cpp [new file with mode: 0644]
llvm/lib/CodeGen/TargetLoweringBase.cpp
llvm/lib/CodeGen/TargetPassConfig.cpp
llvm/lib/Target/X86/X86ISelLowering.cpp
llvm/test/CodeGen/AArch64/O0-pipeline.ll
llvm/test/CodeGen/AArch64/O3-pipeline.ll
llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
llvm/test/CodeGen/ARM/O3-pipeline.ll
llvm/test/CodeGen/M68k/pipeline.ll
llvm/test/CodeGen/PowerPC/O3-pipeline.ll
llvm/test/CodeGen/RISCV/O0-pipeline.ll
llvm/test/CodeGen/RISCV/O3-pipeline.ll
llvm/test/CodeGen/X86/O0-pipeline.ll
llvm/test/CodeGen/X86/expand-large-fp-convert-fptosi129.ll [new file with mode: 0644]
llvm/test/CodeGen/X86/expand-large-fp-convert-fptoui129.ll [new file with mode: 0644]
llvm/test/CodeGen/X86/expand-large-fp-convert-si129tofp.ll [new file with mode: 0644]
llvm/test/CodeGen/X86/expand-large-fp-convert-ui129tofp.ll [new file with mode: 0644]
llvm/test/CodeGen/X86/fp-i129.ll [new file with mode: 0644]
llvm/test/CodeGen/X86/opt-pipeline.ll
llvm/tools/opt/opt.cpp