ksmbd: fix error code in ndr_read_int32()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 30 Nov 2021 12:50:47 +0000 (15:50 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Dec 2021 11:28:57 +0000 (12:28 +0100)
commit89d0ffb4bb960d6ccfac4d01cbd5e0e4727c1ebc
treeef35ca12305a0c23976505013f683dd902f18bcf
parentc99513dffd361d5e2121d3c23c7e840a505db4e1
ksmbd: fix error code in ndr_read_int32()

commit ef399469d9ceb9f2171cdd79863f9434b9fa3edc upstream.

This is a failure path and it should return -EINVAL instead of success.
Otherwise it could result in the caller using uninitialized memory.

Fixes: 303fff2b8c77 ("ksmbd: add validation for ndr read/write functions")
Cc: stable@vger.kernel.org # v5.15
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ksmbd/ndr.c