fbdev: Prevent possible use-after-free in fb_release()
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 5 May 2022 22:04:13 +0000 (00:04 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Fri, 6 May 2022 07:21:20 +0000 (09:21 +0200)
commit89bfd4017e58faaf70411555e7f508495114e90b
treef9f73d58ba65664f9d8774892f0aade0f9870610
parent135332f34ba2662bc1e32b5c612e06a8cc41a053
fbdev: Prevent possible use-after-free in fb_release()

Most fbdev drivers have issues with the fb_info lifetime, because call to
framebuffer_release() from their driver's .remove callback, rather than
doing from fbops.fb_destroy callback.

Doing that will destroy the fb_info too early, while references to it may
still exist, leading to a use-after-free error.

To prevent this, check the fb_info reference counter when attempting to
kfree the data structure in framebuffer_release(). That will leak it but
at least will prevent the mentioned error.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220505220413.365977-1-javierm@redhat.com
drivers/video/fbdev/core/fbsysfs.c