ovl: fix freeze protection bypass in ovl_write_iter()
authorAmir Goldstein <amir73il@gmail.com>
Tue, 18 Sep 2018 13:34:32 +0000 (16:34 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Mon, 24 Sep 2018 08:54:01 +0000 (10:54 +0200)
commit898cc19d8af2d6a80a9f2804b0db2e83c5dd8863
tree771188a58c4632b7615c4bffdffa942b4ed82b22
parent63e132528032ce937126aba591a7b37ec593a6bb
ovl: fix freeze protection bypass in ovl_write_iter()

Tested by re-writing to an open overlayfs file while upper ext4 is frozen:

  xfs_io -f /ovl/x
  xfs_io> pwrite 0 4096
                             fsfreeze -f /ext4
  xfs_io> pwrite 0 4096

  WARNING: CPU: 0 PID: 1492 at fs/ext4/ext4_jbd2.c:53 \
           ext4_journal_check_start+0x48/0x82

After the fix, the second write blocks in ovl_write_iter() and avoids
hitting WARN_ON(sb->s_writers.frozen == SB_FREEZE_COMPLETE) in
ext4_journal_check_start().

Fixes: 2a92e07edc5e ("ovl: add ovl_write_iter()")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/file.c