ALSA: core: Fix unexpected error at replacing user TLV
authorTakashi Iwai <tiwai@suse.de>
Tue, 22 Aug 2017 06:15:13 +0000 (08:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2017 08:21:45 +0000 (10:21 +0200)
commit8989c70d30b60749dccb549ed66f915b646ef038
treea12c8dd50223a8470b091ed2696fa1fa906ea6b2
parent9767a4567831aa897e71474014a6e903345b8d0a
ALSA: core: Fix unexpected error at replacing user TLV

commit 88c54cdf61f508ebcf8da2d819f5dfc03e954d1d upstream.

When user tries to replace the user-defined control TLV, the kernel
checks the change of its content via memcmp().  The problem is that
the kernel passes the return value from memcmp() as is.  memcmp()
gives a non-zero negative value depending on the comparison result,
and this shall be recognized as an error code.

The patch covers that corner-case, return 1 properly for the changed
TLV.

Fixes: 8aa9b586e420 ("[ALSA] Control API - more robust TLV implementation")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/control.c