projects / platform / adaptation / renesas_rcar / renesas_kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cfbf8d4) | patch
firewire: net: fix use after free
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 18 Feb 2014 21:25:15 +0000 (22:25 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 28 Feb 2014 10:02:51 +0000 (11:02 +0100)
commit8987583366ae9e03c306c2b7d73bdb952df1d08d
treeb41f0bbe8ce8d49bc090f6d30e7ab39ee77db023tree | snapshot
parentcfbf8d4857c26a8a307fb7cd258074c9dcd8c691commit | diff
firewire: net: fix use after free

Commit 8408dc1c14c1 "firewire: net: use dev_printk API" introduced a
use-after-free in a failure path.  fwnet_transmit_packet_failed(ptask)
may free ptask, then the dev_err() call dereferenced it.  The fix is
straightforward; simply reorder the two calls.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org # v3.4+
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/net.c diff | blob | history
Domain: System / Uncategorized;