Debugger: use debug break slot to break on call.
authoryangguo <yangguo@chromium.org>
Fri, 10 Jul 2015 08:49:14 +0000 (01:49 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 10 Jul 2015 08:49:31 +0000 (08:49 +0000)
commit8965b683ce39bc3c24ed2466d189323d81a70852
treee8b8f37fccb7ff87254c27ba55efa196407bb396
parent6d12699ab443048cf6a0f84726ea4072f55eb6b5
Debugger: use debug break slot to break on call.

Break point at calls are currently set via IC. To change this, we
need to set debug break slots instead. We also need to distinguish
those debug break slots as calls to support step-in.

To implement this, we add a data field to debug break reloc info to
indicate non-call debug breaks or in case of call debug breaks, the
number of arguments. We can later use this to find the callee on the
evaluation stack in Debug::PrepareStep.

BUG=v8:4269
R=ulan@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/1222093007

Cr-Commit-Position: refs/heads/master@{#29561}
30 files changed:
src/arm/assembler-arm.h
src/arm/debug-arm.cc
src/arm/full-codegen-arm.cc
src/arm64/assembler-arm64.h
src/arm64/debug-arm64.cc
src/arm64/full-codegen-arm64.cc
src/assembler.cc
src/assembler.h
src/builtins.cc
src/builtins.h
src/code-stubs.h
src/debug.cc
src/debug.h
src/disassembler.cc
src/full-codegen.cc
src/full-codegen.h
src/ia32/assembler-ia32.h
src/ia32/debug-ia32.cc
src/ia32/full-codegen-ia32.cc
src/mips/assembler-mips.h
src/mips/debug-mips.cc
src/mips/full-codegen-mips.cc
src/mips64/assembler-mips64.h
src/mips64/debug-mips64.cc
src/mips64/full-codegen-mips64.cc
src/x64/assembler-x64.h
src/x64/debug-x64.cc
src/x64/full-codegen-x64.cc
test/cctest/test-debug.cc
test/mjsunit/debug-stepin-construct-call.js [new file with mode: 0644]