[MIPS][ELF] Use PC-relative relocations in .eh_frame when possible
authorAlex Richardson <Alexander.Richardson@cl.cam.ac.uk>
Sun, 12 Jan 2020 10:55:15 +0000 (10:55 +0000)
committerAlex Richardson <Alexander.Richardson@cl.cam.ac.uk>
Mon, 13 Jan 2020 14:14:03 +0000 (14:14 +0000)
commit894f742acb977a09285dcab024e50c2cf6bce578
tree3fb6f7d27dc63c9359554831b1516a277db3ad04
parent26d2ace9e2305266be888e15392be29e3145163d
[MIPS][ELF] Use PC-relative relocations in .eh_frame when possible

When compiling position-independent executables, we now use
DW_EH_PE_pcrel | DW_EH_PE_sdata4. However, the MIPS ABI does not define a
64-bit PC-relative ELF relocation so we cannot use sdata8 for the large
code model case. When using the large code model, we fall back to the
previous behaviour of generating absolute relocations.

With this change clang-generated .o files can be linked by LLD without
having to pass -Wl,-z,notext (which creates text relocations).
This is simpler than the approach used by ld.bfd, which rewrites the
.eh_frame section to convert absolute relocations into relative references.

I saw in D13104 that apparently ld.bfd did not accept pc-relative relocations
for MIPS ouput at some point. However, I also checked that recent ld.bfd
can process the clang-generated .o files so this no longer seems true.

Reviewed By: atanasyan
Differential Revision: https://reviews.llvm.org/D72228
lld/test/ELF/mips-eh_frame-pic.s [new file with mode: 0644]
llvm/lib/MC/MCObjectFileInfo.cpp
llvm/lib/Object/RelocationResolver.cpp
llvm/test/DebugInfo/Mips/eh_frame.ll
llvm/test/MC/Mips/eh-frame.s