hpsa: avoid unneccesary calls to resource freeing functions
authorRobert Elliott <elliott@hp.com>
Fri, 23 Jan 2015 22:42:54 +0000 (16:42 -0600)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 2 Feb 2015 17:57:39 +0000 (09:57 -0800)
commit8947fd10865db321205faa0e4123d165aff0781c
treeafa72496bef8eff00f52d03526348fe8e920991e
parent2c14334278a614f5573a219d309bc7582ffdd126
hpsa: avoid unneccesary calls to resource freeing functions

If hpsa_allocate_cmd_pool failed, we were calling two functions unnecessarily:

  hpsa_free_sg_chain_blocks(h);
  hpsa_free_cmd_pool(h);

This didn't cause any problem, as those functions can tolerate being called
when what they free hasn't been allocated (relevant pointers would be NULL)
but it is potentially confusing.

Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Signed-off-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/hpsa.c