Delete COMPlus_FinalizeOnShutdown (#23595)
authorJan Kotas <jkotas@microsoft.com>
Sat, 13 Apr 2019 15:09:31 +0000 (08:09 -0700)
committerGitHub <noreply@github.com>
Sat, 13 Apr 2019 15:09:31 +0000 (08:09 -0700)
commit8913aaa1388e263d537b19e78caaed6b124fc0ea
treebd07a13ebfdfdb7c0537eb5969be818f3b735189
parent0fed62e68d1f8f8a756ec8ba5348bfde61057666
Delete COMPlus_FinalizeOnShutdown (#23595)

This compat quirk is increasingly more broken since the framework is generally not compatible with, and we have not heard anybody actually using it.

Changed Environment.HasShutdownStarted to unconditionally return false. It does not make sense for it to ever return true with shutdown finalization disabled.
27 files changed:
src/System.Private.CoreLib/shared/System/Gen2GcCallback.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ConditionalWeakTable.cs
src/System.Private.CoreLib/shared/System/Threading/ThreadPool.cs
src/System.Private.CoreLib/shared/System/Threading/Timer.cs
src/System.Private.CoreLib/src/System/Environment.CoreCLR.cs
src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
src/System.Private.CoreLib/src/System/Reflection/LoaderAllocator.cs
src/System.Private.CoreLib/src/System/Threading/ClrThreadPoolPreAllocatedOverlapped.cs
src/classlibnative/bcltype/system.cpp
src/classlibnative/bcltype/system.h
src/inc/MSCOREE.IDL
src/inc/clrconfigvalues.h
src/pal/prebuilt/inc/mscoree.h
src/utilcode/posterror.cpp
src/vm/appdomain.cpp
src/vm/ceemain.cpp
src/vm/ecalllist.h
src/vm/eepolicy.cpp
src/vm/excep.cpp
src/vm/finalizerthread.cpp
src/vm/finalizerthread.h
src/vm/frames.cpp
src/vm/frames.h
src/vm/threads.cpp
src/vm/threadsuspend.cpp
src/vm/vars.hpp
src/vm/win32threadpool.cpp