x86/ACPI/boot: Use try_cmpxchg() in __acpi_{acquire,release}_global_lock()
authorUros Bizjak <ubizjak@gmail.com>
Mon, 16 Jan 2023 16:25:22 +0000 (17:25 +0100)
committerIngo Molnar <mingo@kernel.org>
Thu, 26 Jan 2023 10:49:40 +0000 (11:49 +0100)
commit890a0794b34f89fcd90e94ec970ad2bc18b70e73
tree480c766e1b0e3405e6792293d569199fa9d8f3f8
parent50fd4d5e6914b60ea6f89c2cbff7a07799414c62
x86/ACPI/boot: Use try_cmpxchg() in __acpi_{acquire,release}_global_lock()

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
__acpi_{acquire,release}_global_lock().  x86 CMPXCHG instruction returns
success in ZF flag, so this change saves a compare after CMPXCHG
(and related MOV instruction in front of CMPXCHG).

Also, try_cmpxchg() implicitly assigns old *ptr value to "old" when CMPXCHG
fails. There is no need to re-read the value in the loop.

Note that the value from *ptr should be read using READ_ONCE() to prevent
the compiler from merging, refetching or reordering the read.

No functional change intended.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/20230116162522.4072-1-ubizjak@gmail.com
arch/x86/kernel/acpi/boot.c