perf script: Show proper message when failed list scripts
authorHe Kuang <hekuang@huawei.com>
Thu, 4 Aug 2016 11:25:42 +0000 (11:25 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 15 Aug 2016 16:17:10 +0000 (13:17 -0300)
commit88ded4d8d94a550624e1827478e13fecf97a7b0a
treeee7590ed37e990e74b1f5bf598075752498b0d21
parent49a7f01064a94c4fd6afb6b4f7e3ccc37d0edf99
perf script: Show proper message when failed list scripts

Perf shows the usage message when perf scripts folder failed to open,
which misleads users to let them think the command is being mistyped.

This patch shows a proper message and guides users to check the
PERF_EXEC_PATH environment variable in that case.

Before:

  $ perf script --list

  Usage: perf script [<options>]
   or: perf script [<options>] record <script> [<record-options>] <command>
   or: perf script [<options>] report <script> [script-args]
   or: perf script [<options>] <script> [<record-options>] <command>
   or: perf script [<options>] <top-script> [script-args]

      -l, --list            list available scripts

After:

  $ perf script --list
  open(/home/user/perf-core/scripts) failed.
  Check for "PERF_EXEC_PATH" env to set scripts dir.

Signed-off-by: He Kuang <hekuang@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1470309943-153909-1-git-send-email-hekuang@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c