vboxsf: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Wed, 10 May 2023 21:11:46 +0000 (21:11 +0000)
committerKees Cook <keescook@chromium.org>
Mon, 22 May 2023 19:35:14 +0000 (12:35 -0700)
commit883f8fe87686d1deef2614b1d3a23ca7e5193dff
tree6ec67dd67a51a461a890cc7f9372d7cda69bbb8d
parent8ca25e00cf817b635f4e80d59b6d07686d74eff0
vboxsf: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230510211146.3486600-1-azeemshaikh38@gmail.com
fs/vboxsf/super.c