fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()
authorHao Li <lihao2018.fnst@cn.fujitsu.com>
Tue, 8 Dec 2020 02:08:43 +0000 (10:08 +0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 10 Dec 2020 22:33:17 +0000 (17:33 -0500)
commit88149082bb8ef31b289673669e080ec6a00c2e59
tree27b73fca304245cc58b3baff803a68b21c6afa27
parentedf7ddbf1c5eb98b720b063b73e20e8a4a1ce673
fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()

If generic_drop_inode() returns true, it means iput_final() can evict
this inode regardless of whether it is dirty or not. If we check
I_DONTCACHE in generic_drop_inode(), any inode with this bit set will be
evicted unconditionally. This is not the desired behavior because
I_DONTCACHE only means the inode shouldn't be cached on the LRU list.
As for whether we need to evict this inode, this is what
generic_drop_inode() should do. This patch corrects the usage of
I_DONTCACHE.

This patch was proposed in [1].

[1]: https://lore.kernel.org/linux-fsdevel/20200831003407.GE12096@dread.disaster.area/

Fixes: dae2f8ed7992 ("fs: Lift XFS_IDONTCACHE to the VFS layer")
Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/inode.c
include/linux/fs.h