media: mxl111sf: Fix potential null pointer dereference
authorEugeniu Rosca <erosca@de.adit-jv.com>
Sun, 13 Aug 2017 10:06:29 +0000 (06:06 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 27 Aug 2017 10:58:19 +0000 (06:58 -0400)
commit87e9201108b7d63cc4a50faca3baad48c4ec99f8
treee222d2464c953c2adecc075fe9b7fc6b86a1ecf0
parent9793e1d214dc62a2685fa33dd0dc59b7f5e838b6
media: mxl111sf: Fix potential null pointer dereference

Reviewing the delta between cppcheck output of v4.9.39 and v4.9.40
stable updates, I stumbled on the new warning:

mxl111sf.c:80: (warning) Possible null pointer dereference: rbuf

Since copying state->rcvbuf into rbuf is not needed in the 'write-only'
scenario (i.e. calling mxl111sf_ctrl_msg() from mxl111sf_i2c_send_data()
or from mxl111sf_write_reg()), bypass memcpy() in this case.

Fixes: d90b336f3f65 ("[media] mxl111sf: Fix driver to use heap allocate buffers for USB messages")

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Michael Ira Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/dvb-usb-v2/mxl111sf.c