watchdog: da9062: No need to ping manually before setting timeout
authorStefan Riedmueller <s.riedmueller@phytec.de>
Fri, 3 Apr 2020 13:07:28 +0000 (15:07 +0200)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:26 +0000 (15:38 -0400)
commit87c06e46629d07d651eb8b21337e3995b932ab4b
tree70314fa0b9db4389d4c8cec4c60aaa0271f9c963
parent6021e1f45162617d857bac7bac89baee6f959fc5
watchdog: da9062: No need to ping manually before setting timeout

[ Upstream commit a0948ddba65f4f6d3cfb5e2b84685485d0452966 ]

There is actually no need to ping the watchdog before disabling it
during timeout change. Disabling the watchdog already takes care of
resetting the counter.

This fixes an issue during boot when the userspace watchdog handler takes
over and the watchdog is already running. Opening the watchdog in this case
leads to the first ping and directly after that without the required
heartbeat delay a second ping issued by the set_timeout call. Due to the
missing delay this resulted in a reset.

Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Link: https://lore.kernel.org/r/20200403130728.39260-3-s.riedmueller@phytec.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/watchdog/da9062_wdt.c