Source/WebCore: Incorrect children placement in multi-column layout.
authorinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Feb 2012 22:26:29 +0000 (22:26 +0000)
committerinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Feb 2012 22:26:29 +0000 (22:26 +0000)
commit87ba340bfdc14cba96a213b3cfb1564278b0c3e7
treef156c8e14858e9d3074dd21b7fbfb93d4810ad74
parent4eac1d0db08c3edf2f22001d0660f003d705b398
Source/WebCore: Incorrect children placement in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

Test: fast/multicol/span/clone-before-after-content-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone): no longer need to take care of making
children noninline (remove fix r105769) since moveChild functions take
care of adding the child properly if type of children differ. this
function just makes sure to set the right value of childrenInline property.
(WebCore::RenderBlock::splitBlocks): similar to moveChild functions below.
(WebCore::RenderBlock::moveChildTo): when child is fullRemoveInsert (across
different parents, e.g clones), we should use addChild function to make sure
it handles the case of different type of children between fromBlock and
toBlock correctly (specifically making children non-inline/wrapping inline
children under anonymous blocks.).
(WebCore::RenderBlock::moveChildrenTo):
* rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::moveAllChildrenTo): Rename to->toBlock.
(WebCore::RenderBlock::moveChildrenTo): Rename to->toBlock.

LayoutTests: Incorrect children placement in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78160

Reviewed by David Hyatt.

* fast/multicol/span/clone-before-after-content-crash-expected.txt: Added.
* fast/multicol/span/clone-before-after-content-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/multicol/span/clone-before-after-content-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/multicol/span/clone-before-after-content-crash.html [new file with mode: 0755]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlock.cpp
Source/WebCore/rendering/RenderBlock.h