RDMA/cma: Distinguish between sockaddr_in and sockaddr_in6 by size
authorKees Cook <keescook@chromium.org>
Wed, 8 Feb 2023 23:25:53 +0000 (15:25 -0800)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 16 Feb 2023 15:20:20 +0000 (11:20 -0400)
commit876e480da2f74715fc70e37723e77ca16a631e35
tree42b52f41c31ac958764ccb88f183230989e1167d
parent5ff31dfcd6d23f9c1bd5dd1a2c648ba499659357
RDMA/cma: Distinguish between sockaddr_in and sockaddr_in6 by size

Clang can do some aggressive inlining, which provides it with greater
visibility into the sizes of various objects that are passed into
helpers. Specifically, compare_netdev_and_ip() can see through the type
given to the "sa" argument, which means it can generate code for "struct
sockaddr_in" that would have been passed to ipv6_addr_cmp() (that expects
to operate on the larger "struct sockaddr_in6"), which would result in a
compile-time buffer overflow condition detected by memcmp(). Logically,
this state isn't reachable due to the sa_family assignment two callers
above and the check in compare_netdev_and_ip(). Instead, provide a
compile-time check on sizes so the size-mismatched code will be elided
when inlining. Avoids the following warning from Clang:

../include/linux/fortify-string.h:652:4: error: call to '__read_overflow' declared with 'error' attribute: detected read beyond size of object (1st parameter)
                        __read_overflow();
                        ^
note: In function 'cma_netevent_callback'
note:   which inlined function 'node_from_ndev_ip'
1 error generated.

When the underlying object size is not known (e.g. with GCC and older
Clang), the result of __builtin_object_size() is SIZE_MAX, which will also
compile away, leaving the code as it was originally.

Link: https://lore.kernel.org/r/20230208232549.never.139-kees@kernel.org
Link: https://github.com/ClangBuiltLinux/linux/issues/1687
Signed-off-by: Kees Cook <keescook@chromium.org>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/core/cma.c