drm/panfrost: Fix module unload
authorSteven Price <steven.price@arm.com>
Fri, 30 Oct 2020 14:58:33 +0000 (14:58 +0000)
committerBoris Brezillon <boris.brezillon@collabora.com>
Tue, 3 Nov 2020 08:43:57 +0000 (09:43 +0100)
commit876b15d2c88d8c005f1aebeaa23f1e448d834757
tree196c794b5b5919a51d1b785d359a0d238c8cd1e0
parent7d2d6d01293e6d9b42a6cb410be4158571f7fe9d
drm/panfrost: Fix module unload

When unloading the call to pm_runtime_put_sync_suspend() will attempt to
turn the GPU cores off, however panfrost_device_fini() will have turned
the clocks off. This leads to the hardware locking up.

Instead don't call pm_runtime_put_sync_suspend() and instead simply mark
the device as suspended using pm_runtime_set_suspended(). And also
include this on the error path in panfrost_probe().

Fixes: aebe8c22a912 ("drm/panfrost: Fix possible suspend in panfrost_remove")
Signed-off-by: Steven Price <steven.price@arm.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201030145833.29006-1-steven.price@arm.com
drivers/gpu/drm/panfrost/panfrost_drv.c