IBM Z: fix `section type conflict` with -mindirect-branch-table
authorIlya Leoshkevich <iii@linux.ibm.com>
Fri, 28 Jan 2022 12:34:24 +0000 (13:34 +0100)
committerIlya Leoshkevich <iii@linux.ibm.com>
Tue, 1 Feb 2022 21:13:38 +0000 (22:13 +0100)
commit8753b13a31c777cdab0265dae0b68534247908f7
treeaa9adbe1c533fd1890d66732fae83f0db9b726ff
parent447047a8f95c6bf4b1873f390c833e91aa8af18c
IBM Z: fix `section type conflict` with -mindirect-branch-table

s390_code_end () puts indirect branch tables into separate sections and
tries to switch back to wherever it was in the beginning by calling
switch_to_section (current_function_section ()).

First of all, this is unnecessary - the other backends don't do it.

Furthermore, at this time there is no current function, but if the
last processed function was cold, in_cold_section_p remains set.  This
causes targetm.asm_out.function_section () to call
targetm.section_type_flags (), which in absence of current function
decl classifies the section as SECTION_WRITE.  This causes a section
type conflict with the existing SECTION_CODE.

gcc/ChangeLog:

* config/s390/s390.cc (s390_code_end): Do not switch back to
code section.

gcc/testsuite/ChangeLog:

* gcc.target/s390/nobp-section-type-conflict.c: New test.
gcc/config/s390/s390.cc
gcc/testsuite/gcc.target/s390/nobp-section-type-conflict.c [new file with mode: 0644]