KVM: VMX: fix use after free of vmx->loaded_vmcs
authorMarcelo Tosatti <mtosatti@redhat.com>
Fri, 3 Jan 2014 19:00:51 +0000 (17:00 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Mar 2014 16:58:14 +0000 (09:58 -0700)
commit8705bd42c90cde02da72650c6a2ed87b65f2179a
tree58467d3dd9565868fe4ac55c147df196fc4ab384
parent0cb2501e5f4bf2d5409fae7bef5f8e7b7a0d015a
KVM: VMX: fix use after free of vmx->loaded_vmcs

commit 26a865f4aa8e66a6d94958de7656f7f1b03c6c56 upstream.

After free_loaded_vmcs executes, the "loaded_vmcs" structure
is kfreed, and now vmx->loaded_vmcs points to a kfreed area.
Subsequent free_loaded_vmcs then attempts to manipulate
vmx->loaded_vmcs.

Switch the order to avoid the problem.

https://bugzilla.redhat.com/show_bug.cgi?id=1047892

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/kvm/vmx.c