sh: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 30 May 2023 16:30:41 +0000 (16:30 +0000)
committerKees Cook <keescook@chromium.org>
Wed, 14 Jun 2023 19:27:20 +0000 (12:27 -0700)
commit870410910b6ad032afb6a02bfd6a8c65dde6084b
tree9d974e636a18c39a20e90e6e6845488eecdf1478
parentfdd932efaec97693e6b383df876712f590f4332a
sh: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230530163041.985456-1-azeemshaikh38@gmail.com
arch/sh/drivers/dma/dma-api.c
arch/sh/kernel/setup.c