Fix VSO 359733. (dotnet/coreclr#8803)
authorPat Gavlin <pgavlin@gmail.com>
Wed, 4 Jan 2017 23:30:13 +0000 (15:30 -0800)
committerGitHub <noreply@github.com>
Wed, 4 Jan 2017 23:30:13 +0000 (15:30 -0800)
commit86e279f81ce11e96204a60ff8dedb4c943c0abf0
tree2e19a28afe5a67e487347f9a0f92146438bcc4ec
parenta908664ee897224e47f0b8a151eac897b4779a8c
Fix VSO 359733. (dotnet/coreclr#8803)

* Fix VSO 359733.

This bug was an assertion when extracting side effects that failed when
checking that the presence or absence of value numbers on the head of
the side effect list matched the presence or absence of value numbers on
the node being added to the list. This condition does not hold when
remorphing, as remorphing may create nodes without value numbers. In
this case, the new comma node will have no value numbers for
conservative correctness. The failing assertion was weakened to allow
the presence/absence of value numbers on the head of the list and the
node being added to differ during remorphing.

Commit migrated from https://github.com/dotnet/coreclr/commit/4af7d40e0eeaa961f55ea8abff2eb03fc5dcdd56
src/coreclr/src/jit/gentree.cpp
src/coreclr/tests/src/JIT/Regression/JitBlue/DevDiv_359733/DevDiv_359733.il [new file with mode: 0644]
src/coreclr/tests/src/JIT/Regression/JitBlue/DevDiv_359733/DevDiv_359733.ilproj [new file with mode: 0644]