Revert "Inlining: Run the legacy AlwaysInliner before the regular inliner."
authorDavid Green <david.green@arm.com>
Fri, 10 Feb 2023 15:01:49 +0000 (15:01 +0000)
committerDavid Green <david.green@arm.com>
Fri, 10 Feb 2023 15:01:49 +0000 (15:01 +0000)
commit86bfeb906e3a95ae428f3e97d78d3d22a7c839f3
tree19ae36a091c443fdbb9f544857104e30683b26fb
parentc4a250ecea14fda4920ddf035318b32b18bca5e5
Revert "Inlining: Run the legacy AlwaysInliner before the regular inliner."

This seems to cause large regressions in existing code, as much as 75% slower
(4x the time taken). Small always inline functions seem to be used a lot in the
cmsis-dsp library.

I would add a phase ordering test to show the problems, but one already exists!
The llvm/test/Transforms/PhaseOrdering/ARM/arm_mult_q15.ll was just changed by
removing alwaysinline to hide the problems that existed.

This reverts commit cae033dcf227aeecf58fca5af6fc7fde1fd2fb4f.
This reverts commit 8e33c41e72ad42e4c27f8cbc3ad2e02b169637a1.
14 files changed:
clang/test/CodeGen/code-coverage.c
clang/test/Frontend/optimization-remark-with-hotness-new-pm.c
clang/test/Headers/__clang_hip_math.hip
clang/test/OpenMP/bug57757.cpp
llvm/lib/Passes/PassBuilderPipelines.cpp
llvm/test/Other/new-pm-defaults.ll
llvm/test/Other/new-pm-print-pipeline.ll
llvm/test/Other/new-pm-thinlto-defaults.ll
llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll
llvm/test/Transforms/Inline/always-inline-phase-ordering.ll [deleted file]
llvm/test/Transforms/PhaseOrdering/ARM/arm_mult_q15.ll