nvmet-loop: Flush nvme_delete_wq when removing the port
authorLogan Gunthorpe <logang@deltatee.com>
Wed, 31 Jul 2019 23:35:32 +0000 (17:35 -0600)
committerSagi Grimberg <sagi@grimberg.me>
Thu, 1 Aug 2019 00:57:17 +0000 (17:57 -0700)
commit86b9a63e595ff03f9d0a7b92b6acc231fecefc29
tree2c64fb11f909916e60bd11b8aa9a8a8707660f8e
parent3aed86731ee2b23e4dc4d2c6d943d33992cd551b
nvmet-loop: Flush nvme_delete_wq when removing the port

After calling nvme_loop_delete_ctrl(), the controllers will not
yet be deleted because nvme_delete_ctrl() only schedules work
to do the delete.

This means a race can occur if a port is removed but there
are still active controllers trying to access that memory.

To fix this, flush the nvme_delete_wq before returning from
nvme_loop_remove_port() so that any controllers that might
be in the process of being deleted won't access a freed port.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by : Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
drivers/nvme/target/loop.c