nvme-tcp: fix nvme_tcp_term_pdu to match spec
authorCaleb Sander <csander@purestorage.com>
Mon, 20 Mar 2023 15:57:36 +0000 (09:57 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2023 10:49:09 +0000 (12:49 +0200)
commit869bb1932bc7c3a572c99a28a18b46a1f7c3c41a
treeb5a40a68b533acb8c2f3986690616871203bcaed
parenta338bd69e55b4bd984ad11e97d0b1da6271c3ba0
nvme-tcp: fix nvme_tcp_term_pdu to match spec

[ Upstream commit aa01c67de5926fdb276793180564f172c55fb0d7 ]

The FEI field of C2HTermReq/H2CTermReq is 4 bytes but not 4-byte-aligned
in the NVMe/TCP specification (it is located at offset 10 in the PDU).
Split it into two 16-bit integers in struct nvme_tcp_term_pdu
so no padding is inserted. There should also be 10 reserved bytes after.
There are currently no users of this type.

Fixes: fc221d05447aa6db ("nvme-tcp: Add protocol header")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Caleb Sander <csander@purestorage.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/nvme-tcp.h