SO_ZEROCOPY should return -EOPNOTSUPP rather than -ENOTSUPP
authorSamuel Thibault <samuel.thibault@labri.fr>
Mon, 7 Mar 2022 22:31:26 +0000 (23:31 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 9 Mar 2022 06:14:49 +0000 (22:14 -0800)
commit869420a8be1982a0be5a934860270058431c9771
tree40d40a7c18f13ae5dbf5844523bb4708476700d9
parent964efdab03490d40d8e458b6a1ddf02aae212567
SO_ZEROCOPY should return -EOPNOTSUPP rather than -ENOTSUPP

ENOTSUPP is documented as "should never be seen by user programs",
and thus not exposed in <errno.h>, and thus applications cannot safely
check against it (they get "Unknown error 524" as strerror). We should
rather return the well-known -EOPNOTSUPP.

This is similar to 2230a7ef5198 ("drop_monitor: Use correct error
code") and 4a5cdc604b9c ("net/tls: Fix return values to avoid
ENOTSUPP"), which did not seem to cause problems.

Signed-off-by: Samuel Thibault <samuel.thibault@labri.fr>
Acked-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20220307223126.djzvg44v2o2jkjsx@begin
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/sock.c