spi: spi-topcliff-pch: Fix potential double free in pch_spi_process_messages()
authorJay Fang <f.fangjian@huawei.com>
Thu, 6 May 2021 07:08:08 +0000 (15:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:55:50 +0000 (16:55 +0200)
commit8692603ff15557715d03f5363fe5314355e6f6d3
treefc5c7cb9eb64f85b3d0261eb3369ee1346acc2d1
parentcb42cf32ce2e96cbe5a67d0bf7eccbae37521c82
spi: spi-topcliff-pch: Fix potential double free in pch_spi_process_messages()

[ Upstream commit 026a1dc1af52742c5897e64a3431445371a71871 ]

pch_spi_set_tx() frees data->pkt_tx_buff on failure of kzalloc() for
data->pkt_rx_buff, but its caller, pch_spi_process_messages(), will
free data->pkt_tx_buff again. Set data->pkt_tx_buff to NULL after
kfree() to avoid double free.

Signed-off-by: Jay Fang <f.fangjian@huawei.com>
Link: https://lore.kernel.org/r/1620284888-65215-1-git-send-email-f.fangjian@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-topcliff-pch.c