[AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`
authorAleksandr Urakov <aleksandr.urakov@jetbrains.com>
Wed, 13 Mar 2019 13:38:12 +0000 (13:38 +0000)
committerAleksandr Urakov <aleksandr.urakov@jetbrains.com>
Wed, 13 Mar 2019 13:38:12 +0000 (13:38 +0000)
commit867c2a7d369c6a067cadead7cd94ad5b391f14b4
treef89c44f8aeecdfca51685cda3d31190d3d8c1c83
parent0c1e5aacd35f42fdce2fdacb0e278d7879caf529
[AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

Summary:
This patch fixes several small problems with external layouts support in
`MicrosoftRecordLayoutBuilder`:
- aligns properly the size of a struct that ends with a bit field. It was
  aligned on byte before, not on the size of the field, so the struct size was
  smaller than it should be;
- adjusts the struct size when injecting a vbptr in the case when there were no
  bases or fields allocated after the vbptr. Similarly, without the adjustment
  the struct was smaller than it should be;
- the same fix as above for the vfptr.
All these fixes affect the non-virtual size of a struct, so they are tested
through non-virtual inheritance.

Reviewers: rnk, zturner, rsmith

Reviewed By: rnk

Subscribers: jdoerfert, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D58544

llvm-svn: 356047
clang/lib/AST/RecordLayoutBuilder.cpp
clang/test/CodeGenCXX/Inputs/override-bit-field-layout.layout
clang/test/CodeGenCXX/Inputs/override-layout-virtual-base.layout [new file with mode: 0644]
clang/test/CodeGenCXX/override-bit-field-layout.cpp
clang/test/CodeGenCXX/override-layout-virtual-base.cpp [new file with mode: 0644]
clang/test/CodeGenCXX/override-layout.cpp