maccess: Fix writing offset in case of fault in strncpy_from_kernel_nofault()
authorAlban Crequy <albancrequy@linux.microsoft.com>
Thu, 10 Nov 2022 08:56:13 +0000 (09:56 +0100)
committerAndrii Nakryiko <andrii@kernel.org>
Fri, 11 Nov 2022 19:44:46 +0000 (11:44 -0800)
commit8678ea06852cd1f819b870c773d43df888d15d46
treea6accda70d5e23d0b3568f9ae322a1b4df9f918d
parent5704bc7e8991164b14efb748b5afa0715c25fac3
maccess: Fix writing offset in case of fault in strncpy_from_kernel_nofault()

If a page fault occurs while copying the first byte, this function resets one
byte before dst.
As a consequence, an address could be modified and leaded to kernel crashes if
case the modified address was accessed later.

Fixes: b58294ead14c ("maccess: allow architectures to provide kernel probing directly")
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Tested-by: Francis Laniel <flaniel@linux.microsoft.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: <stable@vger.kernel.org> [5.8]
Link: https://lore.kernel.org/bpf/20221110085614.111213-2-albancrequy@linux.microsoft.com
mm/maccess.c