Bail on compilation as soon as a job fails.
authorJustin Lebar <jlebar@google.com>
Wed, 24 Feb 2016 21:49:28 +0000 (21:49 +0000)
committerJustin Lebar <jlebar@google.com>
Wed, 24 Feb 2016 21:49:28 +0000 (21:49 +0000)
commit8671c441c37bcd288b8a613a0fcd599daa005932
tree9f69468755d1f3e78010a73d0ad03fb0417c5dfb
parent0e41fa7666028ce54c04926168d015b3ab060f0b
Bail on compilation as soon as a job fails.

Summary:
(Re-land of r260448, which was reverted in r260522 due to a test failure
in Driver/output-file-cleanup.c that only showed up in fresh builds.)

Previously we attempted to be smart; if one job failed, we'd run all
jobs that didn't depend on the failing job.

Problem is, this doesn't work well for e.g. CUDA compilation without
-save-temps.  In this case, the device-side and host-side Assemble
actions (which actually are responsible for preprocess, compile,
backend, and assemble, since we're not saving temps) are necessarily
distinct.  So our clever heuristic doesn't help us, and we repeat every
error message once for host and once for each device arch.

The main effect of this change, other than fixing CUDA, is that if you
pass multiple cc files to one instance of clang and you get a compile
error, we'll stop when the first cc1 job fails.

Reviewers: echristo

Subscribers: cfe-commits, jhen, echristo, tra, rafael

Differential Revision: http://reviews.llvm.org/D17217

llvm-svn: 261774
clang/lib/Driver/Compilation.cpp
clang/test/Driver/output-file-cleanup.c