i3c: master: dw: check return of dw_i3c_master_get_free_pos()
authorTom Rix <trix@redhat.com>
Sat, 8 Jan 2022 15:09:48 +0000 (07:09 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Mar 2022 18:12:37 +0000 (19:12 +0100)
commit8654464086a12f0fb70801ee87bacee713849ca4
tree866b0403edbf04866003766f231df83b250f85a6
parenta80b13642a108949c19ed8ba80386345cd67773e
i3c: master: dw: check return of dw_i3c_master_get_free_pos()

[ Upstream commit 13462ba1815db5a96891293a9cfaa2451f7bd623 ]

Clang static analysis reports this problem
dw-i3c-master.c:799:9: warning: The result of the left shift is
  undefined because the left operand is negative
                      COMMAND_PORT_DEV_INDEX(pos) |
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

pos can be negative because dw_i3c_master_get_free_pos() can return an
error.  So check for an error.

Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220108150948.3988790-1-trix@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i3c/master/dw-i3c-master.c