bonding: handle link transition from FAIL to UP correctly
authorMahesh Bandewar <maheshb@google.com>
Wed, 12 Apr 2017 05:36:00 +0000 (22:36 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Mar 2018 10:00:09 +0000 (11:00 +0100)
commit86138a4972c4c347413f8461cd06f6a947947dfc
treea9f85861e9225e9f1b8a9acc3ead45e6887e8138
parent09604c91cb04979eff200d05e44df845cd0fb7cf
bonding: handle link transition from FAIL to UP correctly

[ Upstream commit fb9eb899a6dc663e4a2deed9af2ac28f507d0ffb ]

When link transitions from LINK_FAIL to LINK_UP, the commit phase is
not called. This leads to an erroneous state causing slave-link state to
get stuck in "going down" state while its speed and duplex are perfectly
fine. This issue is a side-effect of splitting link-set into propose and
commit phases introduced by de77ecd4ef02 ("bonding: improve link-status
update in mii-monitoring")

This patch fixes these issues by calling commit phase whenever link
state change is proposed.

Fixes: de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/bonding/bond_main.c