io_uring: complete request via task work in case of DEFER_TASKRUN
authorMing Lei <ming.lei@redhat.com>
Fri, 14 Apr 2023 07:53:13 +0000 (15:53 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 14 Apr 2023 12:38:23 +0000 (06:38 -0600)
commit860e1c7f8b0b43fbf91b4d689adfaa13adb89452
treecef7900ae6ac92b1928a0ba4cfd9fd2e2f831138
parentb4a72c0589fdea6259720375426179888969d6a2
io_uring: complete request via task work in case of DEFER_TASKRUN

So far io_req_complete_post() only covers DEFER_TASKRUN by completing
request via task work when the request is completed from IOWQ.

However, uring command could be completed from any context, and if io
uring is setup with DEFER_TASKRUN, the command is required to be
completed from current context, otherwise wait on IORING_ENTER_GETEVENTS
can't be wakeup, and may hang forever.

The issue can be observed on removing ublk device, but turns out it is
one generic issue for uring command & DEFER_TASKRUN, so solve it in
io_uring core code.

Fixes: e6aeb2721d3b ("io_uring: complete all requests in task context")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/linux-block/b3fc9991-4c53-9218-a8cc-5b4dd3952108@kernel.dk/
Reported-by: Jens Axboe <axboe@kernel.dk>
Cc: Kanchan Joshi <joshi.k@samsung.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/io_uring.c