xfs: don't zero partial page cache pages during O_DIRECT writes
authorChris Mason <clm@fb.com>
Tue, 2 Sep 2014 02:12:52 +0000 (12:12 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 2 Sep 2014 02:12:52 +0000 (12:12 +1000)
commit85e584da3212140ee80fd047f9058bbee0bc00d5
tree6bc5ead5262bcd4a365af3afce549e5c9c062034
parent22e757a49cf010703fcb9c9b4ef793248c39b0c2
xfs: don't zero partial page cache pages during O_DIRECT writes

xfs is using truncate_pagecache_range to invalidate the page cache
during DIO reads.  This is different from the other filesystems who
only invalidate pages during DIO writes.

truncate_pagecache_range is meant to be used when we are freeing the
underlying data structs from disk, so it will zero any partial
ranges in the page.  This means a DIO read can zero out part of the
page cache page, and it is possible the page will stay in cache.

buffered reads will find an up to date page with zeros instead of
the data actually on disk.

This patch fixes things by using invalidate_inode_pages2_range
instead.  It preserves the page cache invalidation, but won't zero
any pages.

[dchinner: catch error and warn if it fails. Comment.]

cc: stable@vger.kernel.org
Signed-off-by: Chris Mason <clm@fb.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_file.c