ALSA: snd-aoa: add of_node_put() in error path
authorNicholas Mc Guire <hofrat@osadl.org>
Fri, 29 Jun 2018 17:07:42 +0000 (19:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Oct 2018 00:00:50 +0000 (17:00 -0700)
commit85d3dbd8e7f2af3083f8f68db468c9fdebe9d8d2
treebee4b382db273e777183a2246b61a90e0aea65cf
parent3e3f075f72bd2dfcd5211bd1ff3919bc118ad4cd
ALSA: snd-aoa: add of_node_put() in error path

[ Upstream commit 222bce5eb88d1af656419db04bcd84b2419fb900 ]

 Both calls to of_find_node_by_name() and of_get_next_child() return a
node pointer with refcount incremented thus it must be explicidly
decremented here after the last usage. As we are assured to have a
refcounted  np  either from the initial
of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np)
in the while loop if we reached the error code path below, an
x of_node_put(np) is needed.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/aoa/core/gpio-feature.c